Issue information

Issue ID
#7722
Status
Fixed
Severity
None
Started
puzzles
Sep 27, 2013 6:33
Last Post
Haru
Sep 28, 2013 22:17
Confirmation
Yes (2)
No (0)

puzzles - Sep 27, 2013 6:33

The logout and NPC_CALLSLAVE effects are both incorrect. This is an issue that has been present since eAthena. I've tested this in the most recent revision (as of today) of eAthena, rAthena and Hercules and this bug is present in all of them.

This is what the client displays when a player logs out:
[img]http://img268.imageshack.us/img268/4259/slf8.png[/img]
This is the same animation that is used when a player or monster teleports, making it impossible to know from the animation itself if a player has logged out or just teleported.

This is what an NPC's mob looks like when it is called with NPC_CALLSLAVE:
[img]http://img34.imageshack.us/img34/5033/5vd9.png[/img]

On official servers these effects are swapped. The current NPC_CALLSLAVE effect should be the effect used for a player logging out. The NPC_CALLSLAVE effect should be using the current logout effect.

This post has been edited by puzzles on Sep 27, 2013 6:41

puzzles - Sep 27, 2013 21:48

I fixed both issues and sent a pull request. The fixes can be found below:
[url="https://github.com/cannelle/Hercules/commit/84b3b60a846bc01a2bdefcd16f0d345bdc35edda"]Corrected map_quit call with CLR_RESPAWN instead of CLR_TELEPORT.[/url]
[url="https://github.com/cannelle/Hercules/commit/af4d9171df5631968b8e20660856828b5bb346ab"]Corrected mob_warpslave_sub call with CLR_TELEPORT instead of CLR_RESPAWN.[/url]