Compiler error on HPM: Hooking after undefined PACKETVER_RE

Issue information

Issue ID

#7744

Status

Fixed

Severity

None

Started

shenhuyong

Oct 5, 2013 6:46

Last Post

Ind

Oct 8, 2013 0:17

Confirmation

Yes (1)

No (0)

shenhuyong - Oct 5, 2013 6:46

mmo.h[code=auto:0] #ifdef PACKETVER_RE #if (PACKETVER == 20120410) || (PACKETVER == 20120418) #define PARTY_RECRUIT #endif #endif [/code]
After I undefined PACKETVER_RE or PACKETVER isn't 20120410 and 20120418, PARTY_RECRUIT in mmo.h will be undifined ,then the compiler will cause some error on HPM Hooking.

I think it is because that PartyBookingVolunteerInfo,PartyBookingRefuseVolunteer,PartyBookingCancelVolunteer,PartyBookingAddFilteringList,PartyBookingSubFilteringList,pPartyBookingAddFilter,pPartyBookingSubFilter,pPartyBookingReqVolunteer,pPartyBookingRefuseVolunteer and pPartyBookingCancelVolunteer can not be found in clif_interface.

Judas - Oct 5, 2013 13:23

Yeah I get this too

Haru - Oct 5, 2013 16:19

We need to make sure there are no #ifdef inside any of the interfaces, else the code produced by the HPMHooking generator will fail to compile with different settings.

Ind - Oct 7, 2013 16:43

Thanks, fixed in [url="https://github.com/HerculesWS/Hercules/commit/c56e3eb701658079f1de09db759f3b09327ec046"]https://github.com/HerculesWS/Hercules/commit/c56e3eb701658079f1de09db759f3b09327ec046[/url]

shenhuyong - Oct 7, 2013 17:48

Now compiler error on clif.c after undefined PACKETVER_RE

The problem at the line 12193 from clif.c[code=nocode:0] #ifndef PARTY_RECRUIT [/code]

This post has been edited by shenhuyong on Oct 7, 2013 18:00

Ind - Oct 7, 2013 19:52

[quote name="shenhuyong" timestamp="1381168127"]
Now compiler error on clif.c after undefined PACKETVER_RE

The problem at the line 12193 from clif.c[code=nocode:0]#ifndef PARTY_RECRUIT[/code]

[/quote]you sure? I tested that before compiling -- and now too, no errors. what os/compiler?

This post has been edited by Ind on Oct 7, 2013 19:52

shenhuyong - Oct 7, 2013 23:49

You fixed it in [url="https://github.com/HerculesWS/Hercules/commit/95caa2458c92c04c479e0dce18aaeb1e8846c214"]https://github.com/HerculesWS/Hercules/commit/95caa2458c92c04c479e0dce18aaeb1e8846c214[/url]

Ind - Oct 8, 2013 0:17

thanks for letting me know