Safety Wall Reflect Bug / Body Relocation Error

[quote name="xathenx" timestamp="1383149855"]
Skill Issues:

1. I try Asura Strike on Professor with Orc Lord Armor then my damage back to my character even the Professor is inside Safety Wall.[/quote]
[size=4]Working as intended,[/size] [size=4][color=rgb(40,40,40)][font=helvetica, arial, sans-serif]official behavior.[/font][/color][/size]

[size=4][color=rgb(40,40,40)][font=helvetica, arial, sans-serif]@edit[/font][/color][/size]
[size=4][color=rgb(40,40,40)][font=helvetica, arial, sans-serif]#2 How to reproduce?[/font][/color][/size]

[quote]
1. I try Asura Strike on Professor with Orc Lord Armor then my damage back to my character even the Professor is inside Safety Wall.[/quote]
Working as Intended...
[quote]
2. I wonder why some of my player getting error in Body Relocation animation after I update my Server to latest revision.[/quote]
client compatibility..what is your client date...

:meow:

[quote name="xathenx" timestamp="1383149855"]
Skill Issues:

1. I try Asura Strike on Professor with Orc Lord Armor then my damage back to my character even the Professor is inside Safety Wall.

2. I wonder why some of my player getting error in Body Relocation animation after I update my Server to latest revision.[/quote]


#1 same as mine my revision is 12535


#2 i solve it by myself , my case is same as your's but then i tried to find a solution and i found the error, "custom headgears" some of the custom item has an error, even tho, when u try to wear it and nothing's happen, when the champ uses relocation it trigger the behavior or movement of the custom headgear. that's why maybe the custom headgear is lack of details or corrupted. i hope this can help..

[quote name="malufett" timestamp="1383159742"][quote]

1. I try Asura Strike on Professor with Orc Lord Armor then my damage back to my character even the Professor is inside Safety Wall.[/quote]Working as Intended...
[quote]
2. I wonder why some of my player getting error in Body Relocation animation after I update my Server to latest revision.[/quote]client compatibility..what is your client date...

:meow:[/quote][quote name="malufett" timestamp="1383159742"]
My Client date is 03-20-2013[/quote]

[quote name="kyeme" timestamp="1383150286"][quote name="xathenx" timestamp="1383149855"]

Skill Issues:

1. I try Asura Strike on Professor with Orc Lord Armor then my damage back to my character even the Professor is inside Safety Wall.[/quote][size=4]Working as intended,[/size] [size=4][color=rgb(40,40,40)][font=helvetica, arial, sans-serif]official behavior.[/font][/color][/size]

[size=4][color=rgb(40,40,40)][font=helvetica, arial, sans-serif]@edit[/font][/color][/size]
[size=4][color=rgb(40,40,40)][font=helvetica, arial, sans-serif]#2 How to reproduce?[/font][/color][/size][/quote]
Even the enemy is in Safety Wall? I will get my damage back?

@xathenx

Yes. Same with Guard and Parrying, but this can be easily applied into a configuration file (or even a dumb flag in header file, or change the function prototype....) to create the "expected" behavior.

Actually, the main core of the reflect algorithm (in this case) is localized in battle.c: battle_calc_return_damage, but that function not handle the "state" (Sucessfully Block). Just apply 0 on trdamage (or even use constant :D) return statement (Actually max (0,trdamage) ) to force a "miss".

but as other said, this is a official behavior...soo

[quote name="Chiron" timestamp="1383180799"]
@xathenx

Yes. Same with Guard and Parrying, but this can be easily applied into a configuration file (or even a dumb flag in header file, or change the function prototype....) to create the "expected" behavior.

Actually, the main core of the reflect algorithm (in this case) is localized in battle.c: battle_calc_return_damage, but that function not handle the "state" (Sucessfully Block). Just apply 0 on trdamage (or even use constant :D) return statement (Actually max (0,trdamage) ) to force a "miss".

but as other said, this is a official behavior...soo[/quote]
hello sir. I just want to ask what sort of code should i put in the function battle_calc_return_damage to be able to NOT return damage blocked by safetywall/parrying/autoguard

I believe this is the intended behavior only for equip based reflect as shown [url="http://herc.ws/board/tracker/issue-6938-autoguard-safety-wall-with-damage-return/?gopid=15952#entry15952"]here[/url], not for the skill based reflect.
Skill based reflect was also changed by that fix.

Would be nice if someone tested skill based reflect on kRO. I do not believe it should work like this.

[quote name="GrumpyPanda" timestamp="1384573148"]
I believe this is the intended behavior only for equip based reflect as shown [url="http://herc.ws/board/tracker/issue-6938-autoguard-safety-wall-with-damage-return/?gopid=15952#entry15952"]here[/url], not for the skill based reflect.
Skill based reflect was also changed by that fix.

Would be nice if someone tested skill based reflect on kRO. I do not believe it should work like this.[/quote]
yes in kRO same ways with the skill it does reflect..only one thing which is not official the ReflectShield that it will not work only when AutoGuard is active other than that it should work...and ATM can't be fixed cause it needs a major changes in battle.c and don't ask me why cause its hard to explain..:P

:meow:

mkay, shield reflect working with autoguard was actually the bigger imbalance. but nice to know its a known bug.

I took a quick look. wouldn't it be possible to just add a new flag like d->guard = ATK_GUARD when autoguard succesfully blocks, which would then be used to force rdamage=0 ?

I tested in official server (thanks to yommy, haru), the reflect behavior is correct (as stupid as it is)

[quote name="Ind" timestamp="1385494270"]
I tested in official server (thanks to yommy, haru), the reflect behavior is correct (as stupid as it is)[/quote]Sir on official, when autoguard takes effect reflect damage shouldn't take effect anymore. (unless if you have Valk Mantue, Orclord Card)[quote name="malufett" timestamp="1384601931"]
yes in kRO same ways with the skill it does reflect..only one thing which is not official the ReflectShield that it will not work only when AutoGuard is active other than that it should work...and ATM can't be fixed cause it needs a major changes in battle.c and don't ask me why cause its hard to explain.. :P

:meow:[/quote]

indeed, I redid the test and I realised that I my previous results differed due to a mistake. Thanks

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/fdb6de1aa34086fd4d22ae127437727f556cea3c"]https://github.com/HerculesWS/Hercules/commit/fdb6de1aa34086fd4d22ae127437727f556cea3c[/url]

[quote name="Ind" timestamp="1385552828"]
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/fdb6de1aa34086fd4d22ae127437727f556cea3c"]https://github.com/HerculesWS/Hercules/commit/fdb6de1aa34086fd4d22ae127437727f556cea3c[/url][/quote]

Sir, reflect-inflicting items like orc lord card should always inflict reflect even if autoguarded. And in our version now, the skillname overhead "reflect shield" no longer appears on the attacker. This is not the case for official servers.

there we go [url="https://github.com/HerculesWS/Hercules/commit/ae13db97ea770e37450e4e2c1a7919ce98d705a8"]https://github.com/HerculesWS/Hercules/commit/ae13db97ea770e37450e4e2c1a7919ce98d705a8[/url]

Bump, I'm not sure if I'm supposed to make another topic since this is related. Right now I'm able to reflect dmg using reflect shield on safety wall regardless of using auto-guard or not. It's a foolproof way to farm most mobs including Valkyries without inflicting or receiving any damage and was wondering if it can be fixed somehow :c

Bump again after 2 weeks, players are now abusing this bug.

Safetywall + Reflect Shield = Free mvp.

Bumping this too cause it's a pretty serious and abusable bug.

Making a new topic might be better though.