Issue information

Issue ID
#7793
Status
Needs more Info
Severity
None
Started
Beret
Oct 31, 2013 13:09
Last Post
Beret
Nov 2, 2013 23:06
Confirmation
N/A

Beret - Oct 31, 2013 13:09

I was looking at the aegis file and noticed that some items have the initial value of Random equal to 2, if you add in hercules random = 2 and item have drop box will soon crash occurs in server map because the current code is configured to follow a sequence 0, 1, 2, 3 or error will occur if I skip any numbers.

[code=:0] Adv_Siege_Supply_Box: { Siege_White_Potion: { Random: 2 Count: 50 Named: true } Siege_Blue_Potion: { Random: 3 Count: 20 Named: true } } [/code]

Ind - Oct 31, 2013 18:24

i'd say its unintended behavior but regardless, the server should not crash (skipping and a error message would be good)

Ind - Nov 2, 2013 20:55

I was unable to reproduce the crash, I however made it throw a error message when doing this

Beret - Nov 2, 2013 21:15

First crash here, try with this item.
[code=:0] Special_Box: { Aspersio_5_Scroll: { Random: 2 Rate: 3000 Named: true } Poison_Bottle: { Random: 2 Count: 2 Rate: 10 Named: true } Set_Of_Taiming_Item: { Random: 2 Rate: 5 Named: true } Cookie_Bag: { Random: 3 Count: 2 Rate: 100 Named: true } Mysterious_Can2: { Random: 3 Count: 3 Rate: 80 Named: true } Mysterious_PET_Bottle2: { Random: 3 Count: 3 Rate: 80 Named: true } Speed_Up_Potion: { Random: 4 Count: 2 Rate: 80 Named: true } Old_Blue_Box: { Random: 4 Rate: 19 Named: true } Branch_Of_Dead_Tree: { Random: 5 Count: 5 Rate: 14 Named: true } First_Aid_Kit: { Random: 5 Rate: 19 Named: true } Dried_Yggdrasilberry: { Random: 6 Count: 3 Rate: 70 Named: true } Angeling_Potion: { Random: 6 Count: 3 Rate: 70 Named: true } Ygnizem_Scroll: { Random: 6 Count: 2 Rate: 50 Named: true } Doppelganger_Scroll: { Random: 7 Count: 2 Rate: 50 Named: true } Wild_Rose_Scroll: { Random: 7 Count: 2 Rate: 60 Named: true } Gift_Box: { Random: 7 Rate: 70 Named: true } Red_Bag: { Random: 7 Count: 3 Rate: 70 Named: true } Cool_Summer_Outfit: { Random: 8 Count: 3 Rate: 70 Named: true } Slow_Down_Potion: { Random: 8 Count: 2 Rate: 80 Named: true } } [/code]

Ind - Nov 2, 2013 22:08

does it crash during loading or when you use the item?

Ind - Nov 2, 2013 22:27

Added the error message in [url="https://github.com/HerculesWS/Hercules/commit/5e002a43399f5358b7aabd1bd653f598f35287e2"]https://github.com/HerculesWS/Hercules/commit/5e002a43399f5358b7aabd1bd653f598f35287e2[/url] awaiting for more info on the crash

Beret - Nov 2, 2013 23:06

[quote name="Ind" timestamp="1383430105"]
does it crash during loading or when you use the item?[/quote]

error happens when I use the box and leaves some item.