Issue information

Issue ID
#7818
Status
Fixed
Severity
None
Started
sevenzz23
Nov 11, 2013 5:23
Last Post
sevenzz23
Nov 11, 2013 5:45
Confirmation
N/A

sevenzz23 - Nov 11, 2013 5:23

[code=:0] 3>c:\hercules\trunk\src\map\script.c(393): error C2143: syntax error : missing ';' before 'type' 3>c:\hercules\trunk\src\map\script.c(394): error C2065: 's' : undeclared identifier 3>c:\hercules\trunk\src\map\script.c(394): warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int' 3>c:\hercules\trunk\src\map\script.c(394): warning C4024: 'stricmp' : different types for formal and actual parameter 1 3>c:\hercules\trunk\src\map\script.c(395): error C2065: 's' : undeclared identifier 3>c:\hercules\trunk\src\map\script.c(395): warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int' 3>c:\hercules\trunk\src\map\script.c(395): warning C4024: 'strcmp' : different types for formal and actual parameter 1 3>c:\hercules\trunk\src\map\script.c(396): error C2065: 's' : undeclared identifier [/code]
Solution:
[code=:392] Assert( i >= 0 && i < script->local_casecheck_str_size ); const char *s = script->local_casecheck_str_buf+script->local_casecheck_str_data[i].str; [/code]


to[code=:392] const char *s = script->local_casecheck_str_buf+script->local_casecheck_str_data[i].str; Assert( i >= 0 && i < script->local_casecheck_str_size ); [/code]
sorry cant make a pull req.

Haru - Nov 11, 2013 5:36

Thank you, fixed in [url="https://github.com/HerculesWS/Hercules/commit/6e1980bf17132d7540832226aa33512e95e7a261"]https://github.com/HerculesWS/Hercules/commit/6e1980bf17132d7540832226aa33512e95e7a261[/url]

Used a slightly different approach because the assert needs to be before the array lookup.

sevenzz23 - Nov 11, 2013 5:45

okay, thanks :)