Issue information

Issue ID
#7836
Status
Fixed
Severity
None
Started
Poison
Nov 18, 2013 9:11
Last Post
AnnieRuru
Mar 20, 2014 20:57
Confirmation
Yes (1)
No (1)

Poison - Nov 18, 2013 9:11

Weight and MaxWeight character variables are not displaying correct values. There is always an excess of one zero at the end of the value.

e.g. Weight: 2330, Displays: 23300


I have only tested Weight and MaxWeight. I am not sure about the other permanent character-based variables.

hemagx - Nov 18, 2013 9:31

that normal.

kyeme - Nov 18, 2013 9:35

Working as intended

1 = 0.1 weight (ex. arrow)
10 = 1 weight

Poison - Nov 18, 2013 9:55

I don't get it, it should not be the same?

mes "Weight: ^666666"+Weight+"/"+MaxWeight+"^000000";

kyeme - Nov 18, 2013 10:15

[quote name="Poison" timestamp="1384768508"]
I don't get it, it should not be the same?

mes "Weight: ^666666"+Weight+"/"+MaxWeight+"^000000";[/quote]
Ahh you mean in scriptcommand? Im not sure if this is supposed to be intended or not..


Try this, I hope I helped.[code=auto:0] mes " "+(Weight / 10)+" "+(MaxWeight / 10)+" "; [/code]

Poison - Nov 18, 2013 10:22

Thank you for your response Kyeme.

That would work, but that is heuristic coding. This issue needs permanent fix if proven a bug.

I do not like additional computations for getting actual result. :(

Kindly confirm "yes" if confirmed.

Thank you!

malufett - Nov 18, 2013 10:30

[quote name="Poison" timestamp="1384770155"]
Thank you for your response Kyeme.

That would work, but that is heuristic coding. This issue needs permanent fix if proven a bug.

I do not like additional computations for getting actual result. :(

Kindly confirm "yes" if confirmed.

Thank you![/quote]
you can't check if a character is totally empty with that..and as we know many script has that check specially job change script...

:meow:

Poison - Nov 18, 2013 10:38

If that is the case, script document must be more specific.
[quote]
Weight - Amount of weight the character currently carries.
MaxWeight - Maximum weight the character can carry.[/quote]

In this case, its not as it says it is.

KeiKun - Nov 18, 2013 10:46

Weight on scriptcommand
should be updated with

this
[quote]
Weight is divided by 10 since 10 weight in coding make 1 whole actual weight. [Rytech][/quote]

and please fix

Haru - Nov 21, 2013 17:30

Marking as confirmed for the documentation part - some clarification in script_commands.txt wouldn't hurt, to spare some confusion to scripters.

AnnieRuru - Mar 20, 2014 20:57

Fix in
[url="https://github.com/HerculesWS/Hercules/commit/4e73bda7d56db627d98608ba7b12711568766b79"]https://github.com/HerculesWS/Hercules/commit/4e73bda7d56db627d98608ba7b12711568766b79[/url]

I add as many places that I can think