Issue information

Issue ID
#7855
Status
Fixed
Severity
None
Started
N e s s
Nov 25, 2013 23:49
Last Post
Ind
Nov 26, 2013 6:32
Confirmation
Yes (1)
No (0)

N e s s - Nov 25, 2013 23:49

Warning 1 warning C4244: '=' : conversion from 'short' to 'char', possible loss of data d:\program files (x86)\hercules\src\map\clif.c 4607 1 map-server
Error 2 error C2039: 'group' : is not a member of 'unit_interface' d:\program files (x86)\hercules\src\map\clif.c 4613 1 map-server

sevenzz23 - Nov 26, 2013 0:53

Error acquired on rev. 13318

Confirmed[code=auto:0]3>..\src\map\clif.c(4607): warning C4244: '=' : conversion from 'short' to 'char', possible loss of data 3>..\src\map\clif.c(4613): error C2039: 'group' : is not a member of 'unit_interface' 3> ..\src\map\unit.h(74) : see declaration of 'unit_interface'[/code]


clif.c[code=auto_linenums:4606]#if PACKETVER >= 20110718 p.RadiusRange = su->range; // <- Conversion of short to char possible lost of data #endif p.isVisible = 1; #if PACKETVER >= 20130731 p.level = (unsigned char)unit->group->skill_lv; // <- I think it must be su->group->skill_lv #endif[/code]

This post has been edited by sevenzz23 on Nov 26, 2013 3:48

ossi0110 - Nov 26, 2013 6:23

Confirm same on Linux running in PRE-RE Mode

Ind - Nov 26, 2013 6:32

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/1fea20bd718cb3c694dd9aaae67352b894184ddb"]https://github.com/HerculesWS/Hercules/commit/1fea20bd718cb3c694dd9aaae67352b894184ddb[/url]