Issue information

Issue ID
#7858
Status
Fixed
Severity
None
Started
kyeme
Nov 26, 2013 14:19
Last Post
Haru
Dec 20, 2015 16:16
Confirmation
N/A

kyeme - Nov 26, 2013 14:19

Monster announcement rare drop is at msgstringtable.txt line#1629 in the official server, yet in hercules it's at message.conf line#541

[code=auto:0]// Make broadcast ** Player1 won Pupa's Pupa Card (chance 0.01%) *** // This can be set to any value between 0~10000. // Note: It also announces STEAL skill usage with rare items // 0 = don't show announces at all // 1 = show announces for 0.01% drop chance items // 333 = show announces for 3.33% or lower drop chance items // 10000 = show announces for all items rare_drop_announce: 0[/code]

Official (pRO) line#1629:[code=auto:0]Citizens of Midgard, Lady Luck shines upon [%s] !! [%s] has awarded the player with '%s' !!#[/code]
Hercules:[code=auto:0]541: '%s' got %s's %s (chance: %0.02f%%)[/code]

[img]http://i.imgur.com/Q6Vy1Yn.jpg[/img]

Suggestion: [url="http://herc.ws/board/topic/1342-official-drop-announcement/?hl=announce#entry9742"]http://herc.ws/board/topic/1342-official-drop-announcement/?hl=announce#entry9742[/url]

This post has been edited by kyeme on Nov 26, 2013 14:53

Beret - Nov 26, 2013 14:48

[color=rgb(0,0,0)][font=Arial][size=3]Like I said [/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]before [/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]the [/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]package [/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]item [/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]package [/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]is the same as for [/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]rare [/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]drops[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3].[/size][/font][/color]

[code=:0] // packet: 0x7fd // Note: Wery Strange Packet, one of a kind with variable inner struct struct PACKET_ZC_BROADCASTING_SPECIAL_ITEM_OBTAIN { /* this+0x0 */ short PacketType /* this+0x2 */ short PacketLength /* this+0x4 */ unsigned char type { TYPE_BOXITEM = 0x0, TYPE_MONSTER_ITEM = 0x1, } /* this+0x5 */ unsigned short ItemID /* this+0x7 */ struct VarString Holder { // related to MSI_BROADCASTING_SPECIAL_ITEM_OBTAIN = 0x65c /* this+0x0 */ char len /* this+0x1 */ char Name[...] } if (packet.type == TYPE_BOXITEM) { /* this+0x... */ unsigned short BoxItemID } else if (packet.type == TYPE_MONSTER_ITEM) { /* this+0x... */ struct VarString Monster { /* this+0x0 */ char len /* this+0x1 */ char Name[...] } } } [/code]

This post has been edited by Beret on Nov 26, 2013 14:52

kyeme - Nov 26, 2013 14:52

[quote name="Beret" timestamp="1385477328"]
[color=rgb(0,0,0)][font=Arial][size=3]Like I said[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]before[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]the[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]package[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]item[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]package[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]is the same as for[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]rare[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3]drops[/size][/font][/color][color=rgb(0,0,0)][font=Arial][size=3].[/size][/font][/color]
[code=auto:0]// packet: 0x7fd// Note: Wery Strange Packet, one of a kind with variable inner structstruct PACKET_ZC_BROADCASTING_SPECIAL_ITEM_OBTAIN { /* this+0x0 */ short PacketType /* this+0x2 */ short PacketLength /* this+0x4 */ unsigned char type { TYPE_BOXITEM = 0x0, TYPE_MONSTER_ITEM = 0x1, } /* this+0x5 */ unsigned short ItemID /* this+0x7 */ struct VarString Holder { // related to MSI_BROADCASTING_SPECIAL_ITEM_OBTAIN = 0x65c /* this+0x0 */ char len /* this+0x1 */ char Name[...] } if (packet.type == TYPE_BOXITEM) { /* this+0x... */ unsigned short BoxItemID } else if (packet.type == TYPE_MONSTER_ITEM) { /* this+0x... */ struct VarString Monster { /* this+0x0 */ char len /* this+0x1 */ char Name[...] } }}[/code][/quote]

Yes, I wish this will be implemented :)

This post has been edited by kyeme on Nov 26, 2013 14:57

Ind - Nov 28, 2013 15:23

[url="https://github.com/HerculesWS/Hercules/commit/2761bb0af9ddfa8bd14cefa9b6e1b33b2940e7be"]https://github.com/HerculesWS/Hercules/commit/2761bb0af9ddfa8bd14cefa9b6e1b33b2940e7be[/url]