mineffect - Hercules bug tracker archive

Issue information

Issue ID

#7868

Status

Duplicate

Severity

None

Started

kyeme

Nov 28, 2013 14:34

Last Post

kyeme

Dec 16, 2015 11:15

Confirmation

Yes (1)

No (0)

kyeme - Nov 28, 2013 14:34

Everytime I use the command, /mineffect or /minimize, and I warped, the /mineffect goes off so I have to redo or retype the command.

Im using 2013-08-07 client.. Please confirm Thank you! :)

This post has been edited by kyeme on Nov 28, 2013 16:12

malufett - Dec 3, 2013 3:16

its on Ind's to do?? it think..[code=auto:0] p.flag.mineffect = map_flag_gvg(bl->m); // FIXME/CHECKME Forcing /mineffect in castles during WoE (probably redundant? I'm not sure) p.flag.nolockon = 0; // TODO p.flag.countpk = map->list[bl->m].flag.pvp ? 1 : 0; p.flag.nopartyformation = map->list[bl->m].flag.partylock ? 1 : 0; p.flag.bg = map->list[bl->m].flag.battleground ? 1 : 0; p.flag.noitemconsumption = 0; // TODO p.flag.summonstarmiracle = 0; // TODO p.flag.usecart = 1; // TODO [/code]

:meow:

Haru - Dec 3, 2013 16:23

I'm the one who added the 'TODO' flags there (back when I fixed the .party and .guild flags in commit [url="https://github.com/HerculesWS/Hercules/commit/605fe977"]605fe977[/url]), as I didn't really know how to handle the .mineffect flag, and I had no Aegis server to test with.

Can you check if changing the line[code=auto:0] p.flag.mineffect = map_flag_gvg(bl->m); // FIXME/CHECKME Forcing /mineffect in castles during WoE (probably redundant? I'm not sure) [/code]to[code=auto:0] p.flag.mineffect = 1; [/code]yields the desired result?

malufett - Dec 4, 2013 0:16

ah..ok let me do the trick..:D

:meow:

Ind - Dec 5, 2013 17:16

would it be that this data needs to be sent when the map doesn't disable it like gvg?[code=auto:0] void clif_parse_LessEffect(int fd, struct map_session_data* sd) { int isLess = RFIFOL(fd,packet_db[RFIFOW(fd,0)].pos[0]); sd->state.lesseffect = ( isLess != 0 ); } [/code]

malufett - Dec 6, 2013 11:13

[quote name="Ind" timestamp="1386263762"]
would it be that this data needs to be sent when the map doesn't disable it like gvg?[code=auto:0]void clif_parse_LessEffect(int fd, struct map_session_data* sd){ int isLess = RFIFOL(fd,packet_db[RFIFOW(fd,0)].pos[0]); sd->state.lesseffect = ( isLess != 0 );}[/code][/quote]
this is for /effect...hehehe

and I can't capture if the client sends something when typing /mineffect...

@Haru
still the same however the other way around...hhehe

:meow:

This post has been edited by malufett on Dec 6, 2013 11:15

kyeme - May 5, 2014 4:41

Up~

Beret - Dec 7, 2014 23:02

[color=rgb(68,68,68)][font='Segoe UI']That's[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']a[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']mapflag[/font][/color][color=rgb(68,68,68)][font='Segoe UI'].[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']When[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']it is[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']enabled[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']will[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']simplify[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']the effects[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']on a map[/font][/color][color=rgb(68,68,68)][font='Segoe UI'],[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']if I'm not mistaken[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']he[/font][/color][color=rgb(68,68,68)][font='Segoe UI']applies the [/font][/color][color=rgb(68,68,68)][font='Segoe UI']/mineffect[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']command[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']on a map.[/font][/color]

[color=rgb(68,68,68)][font='Segoe UI']Aegis:[/font][/color][code=:0] // //Force Simplified Effects // //TRUE: Simplified effects are used. // ADD_PROPERTY(USE_SIMPLE_EFFECT, TRUE); [/code]

[color=rgb(68,68,68)][font='Segoe UI']This[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']flag[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']is applied[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']on the maps[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']of[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']guild[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']event[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']and[/font][/color][color=rgb(68,68,68)][font='Segoe UI'] [/font][/color][color=rgb(68,68,68)][font='Segoe UI']woe.[/font][/color]

Michi - Dec 8, 2014 21:48

should be fixed here: [url="https://github.com/HerculesWS/Hercules/commit/75444c75ec0e5507640aef91933d94aa87fc7e09"]https://github.com/HerculesWS/Hercules/commit/75444c75ec0e5507640aef91933d94aa87fc7e09[/url]

kyeme - Dec 30, 2014 2:41

Still not fixed. :(

csnv - Jan 4, 2015 14:32

Can it be really fixed? I don't think the client sends anything to the server when enabling/disabling mineffect.

malufett - Jan 4, 2015 17:06

[quote name="csnv" timestamp="1420381928"]
Can it be really fixed? I don't think the client sends anything to the server when enabling/disabling mineffect.[/quote]
the only remedy is implementing mapflag for it..enabling it in a certain map
as Beret pointed out..[code=auto:0] ADD_PROPERTY(USE_SIMPLE_EFFECT, TRUE); [/code]

:meow:

csnv - Jan 4, 2015 17:11

That's only for setting it in a map. The bug is making the user choice (/mineffect) persistent on map change.

malufett - Jan 4, 2015 19:35

[quote name="csnv" timestamp="1420391464"]
That's only for setting it in a map. The bug is making the user choice (/mineffect) persistent on map change.[/quote]
then what to use?the client don't even send anything when using /mineffect...anyway that mapflag is officially used to forced players to set in mineffect when going to a certain maps like woe map..

:meow:

csnv - Jan 4, 2015 20:01

[quote name="malufett" timestamp="1420400158"]
then what to use?the client don't even send anything when using /mineffect[/quote]

Yes, that's what I said. That's why I ask if it can be fixed or, as I understand it, we'll have to change the status to "unable to fix".

This post has been edited by csnv on Jan 4, 2015 20:06

Beret - Feb 14, 2015 3:19

bump

Beret - May 9, 2015 16:10

Bump

kyeme - Dec 16, 2015 11:15

[url="https://github.com/HerculesWS/Hercules/issues/803"]https://github.com/HerculesWS/Hercules/issues/803[/url]