About pass variable type as function parameter - Hercules bug tracker archive

Issue information

Issue ID

#7901

Status

Fixed

Severity

None

Started

Angelmelody

Dec 15, 2013 16:12

Last Post

Haru

Dec 30, 2013 15:35

Confirmation

N/A

Angelmelody - Dec 15, 2013 16:12

Some script commands(getchipã€npcskill ã€unitskilluseid..etc...) can't pass a variable type as parameter. Found the issue on [url="http://rathena.org/board/topic/89125-getcharip-with-variable/"]rathena forum[/url] , and it also happens to Hercules

[quote]
prontera,156,178,3 script IPcheck 952,{

//input character name
input .@Name$;
mes getcharip(.@Name$);
end;
}[/quote]

Can any dev fix this issue?

This post has been edited by Angelmelody on Dec 15, 2013 16:13

Haru - Dec 16, 2013 0:32

The command doesn't correctly check for variables, but only for actual strings. To fix it, it needs some additional code (similar to what countitem does for example)

Edit: If anyone happens to work on this before I do (I might not be able to before the end of the week), please make sure you doublecheck all commands for similar issues.

This post has been edited by Haru on Dec 16, 2013 1:24

Haru - Dec 30, 2013 15:35

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/fefaf392529f71debc63294ed6ee01938cb73eff"]https://github.com/HerculesWS/Hercules/commit/fefaf392529f71debc63294ed6ee01938cb73eff[/url] (sorry for the delay, I had some internet issues in the past days)