ossi0110 - Jan 6, 2014 22:01
When Using a Pet Incubator ID(643) + Poring Egg (ID9001)
you will get disconnected from server when used the pet uncubator on the Poring egg.
disconnecting from server.......
Map Server dont drops a Packet error Warning.
when login back after the Disconect the Poring pet is there.
[url="http://upic.me/show/48982438"][img]http://upic.me/t/81/akeo1.jpg[/img][/url]
Tepoo - Jan 6, 2014 22:15
can confirm this.
Tepoo - Jan 7, 2014 20:19
after some research
void clif_parse_SelectEgg(int fd, struct map_session_data *sd)
line 13355 in clif.c.
this method gets called twice when a pet_incubator is used. on the second run he runs into
[code=:0]
if (sd->menuskill_id != SA_TAMINGMONSTER || sd->menuskill_val != -1) {
//Forged packet, disconnect them [Kevin]
clif->authfail_fd(fd, 0);
return;
}
[/code]
sd->menuskill_id != SA_TAMINGMONSTER is true in the second run.
that cause the client to dc.
themon - Jan 9, 2014 16:23
confirmed
disconnect after using pet incubator and after login still got pet egg but no pet incubator.
themon - Jan 15, 2014 9:09
[quote name="Tepoo" timestamp="1389125992"]
after some research
void clif_parse_SelectEgg(int fd, struct map_session_data *sd)
line 13355 in clif.c.
this method gets called twice when a pet_incubator is used. on the second run he runs into
[code=auto:0]if (sd->menuskill_id != SA_TAMINGMONSTER || sd->menuskill_val != -1) { //Forged packet, disconnect them [Kevin] clif->authfail_fd(fd, 0); return; }[/code]sd->menuskill_id != SA_TAMINGMONSTER is true in the second run.
that cause the client to dc.
[/quote]
I just temporary put comment on this line and the pet hatch without error
Ind - Jan 15, 2014 18:24
its the game client's fault for sending the same packet twice, removing authfail should fix it indeed.
Ind - Jan 15, 2014 18:49
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/533ff4f5ea21695edf89cd94ef06eb89f5a5aa7d"]https://github.com/HerculesWS/Hercules/commit/533ff4f5ea21695edf89cd94ef06eb89f5a5aa7d[/url]