over brand

here is the official path...
[img]http://i44.tinypic.com/33zg3t0.png[/img]
Pierce is the highest damage
Swing is where knockback happens + knockback bonus
Pierce and Swing is where 2 hits happen

:meow:

i try any cell but it hit only once :(

check your copy maybe?
[code=auto:0] case LG_OVERBRAND: { uint8 dir = map->calc_dir(src, x, y); uint8 x2 = x = src->x, y2 = y = src->y; switch( dir ){ case 0: case 1: case 7: x2++; x--; y2 += 7; break; case 3: case 4: case 5: x2++; x--; y -= 7; break; case 2: y2++; y--; x -= 7;break; case 6: y2++; y--; x2 += 7;break; } map->foreachinarea(skill->area_sub, src->m, x, y, x2, y2, BL_CHAR, src, skill_id, skill_lv, tick, flag|BCT_ENEMY|SD_ANIMATION|1,skill->castend_damage_id); skill->addtimerskill(src,timer->gettick() + status_get_amotion(src), 0, 0, 0, LG_OVERBRAND_BRANDISH, skill_lv, dir, flag); } break; [/code]

[img]http://i40.tinypic.com/4gx77.jpg[/img]

:meow:

so if the player whos having the damage not pushed over the wall it will only take 1 damage?

and by the way is hercules now supports up to level 175?

[quote name="N e s s" timestamp="1389538965"]
so if the player whos having the damage not pushed over the wall it will only take 1 damage?[/quote]
no..actually the image I posted above should be 3 hits the piercing, swing and the knockback bonus..however only two captured...
and it will never be 1 hit even knockback except if outside the pierce+swing area or it misses..

this is the full 3 hits..
[img]http://i43.tinypic.com/1498cbd.jpg[/img]
:meow:

[quote name="N e s s" timestamp="1389539132"]
and by the way is hercules now supports up to level 175?[/quote]
ah..in my screen shots...the suppose 'Level limit break' update to be commited soon is still intact in my latest hercules.. :P

:meow:

ok sir malufett :) thanks you sir! :)

but when use it from players it only hit once in any cell why?

[img]http://i41.tinypic.com/5zpmwl.jpg[/img]
in this SS the target receive 2 hits..and no 3rd hit since already dead before collision to the wall...

:meow:

[URL=https://imageshack.com/i/mj7qxvj][img]http://imagizer.imageshack.us/v2/800x600q90/811/7qxv.jpg[/img][/URL]

[URL=https://imageshack.com/i/gvsarkj][img]http://imagizer.imageshack.us/v2/800x600q90/607/sark.jpg[/img][/URL]

same here, it only does the piercing damage, i believe this happens after applying the script for #overbrandhittingtargetsinhide

hmm..weird after updating my files now I produce the bug.. i didn't see any conflicts with Haru and Ind's commit..anyway let me check..

edit:
I know now the problem(skill_db.txt not updated)..my tortoise do trolling me again I have the same files in testing and commiting updates so no conflicts in confirming..it shows it was unmodified but eventually its not commited..haaaiiss..sorry for the inconvenience..

:meow:

sir! is OB already fixed? i mean the hit? :)

can't commit the fix atm..anyway here it is

@skill_db.txt

[color=#ff0000]-2317,1,6,2,-1,0x2,5,5,1,yes,0,0,0,none,3:4:5:6:7, LG_OVERBRAND,Over Brand //CHECK I know the splash is needed somehow for the strange AoE it gives.[/color]
[color=#00ff00]+2317,2,6,2,-1,0x2,0,5,1,yes,0,0,0,weapon,0, LG_OVERBRAND,Over Brand[/color]

2325,0,6,4,0,0x1,0,5,1,yes,0,0,0,none,0, LG_INSPIRATION,Inspiration
[color=#00ff00]+2519,1,6,1,-1,0x2,0,5,1,yes,0,0,0,weapon,3:4:5:6:7, LG_OVERBRAND_BRANDISH,Over Brand[/color]

:meow:

hi sir maluffet! is this patch been comitted already? :) because i want the official one! thank you sir!

Fixed @ 4c735df7d013901c5fc79984bd2206d2109f53d8

:meow: