[Royal Guard] Exceed Break Causes Map Server Crash

[color=#009acd][font='trebuchet ms', helvetica, sans-serif]Using Clean last Git revision, Failed to reproduce, it ddnt. crashed after using Exceed Break 2x..[/font][/color]

[color=#009acd][font='trebuchet ms', helvetica, sans-serif]Maybe there something in your src modification that affects your map server causing it to crashed.[/font][/color]
[color=#009acd][font='trebuchet ms', helvetica, sans-serif][img]http://i41.tinypic.com/2805bg0.jpg[/img][/font][/color]

that's weird,
last 30 minutes, i did with clean GIT, and got map server crash. -,-

Couldn't reproduce either

EDIT:
Just checked following Malufett's instructions and could reproduce

[color=#009acd][font='trebuchet ms', helvetica, sans-serif]pleas run [url="http://herc.ws/wiki/MSVC_Crash_Debugging"]http://herc.ws/wiki/MSVC_Crash_Debugging[/url][/font][/color]

it will crashed if you don't have weapons equipped...

:meow:

Open db/re/skill_require_db.txt and find:[code=auto:0] 2316,0,0,24:28:32:36:40,0,0,0,99,0,0,none,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 //LG_EXEEDBREAK#Exceed Break# [/code]Replace it with:[code=auto:0] 2316,0,0,24:28:32:36:40,0,0,0,2:3:4:5,0,0,none,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 //LG_EXEEDBREAK#Exceed Break# [/code]Also, open your src/map/skill.c and find:[code=auto:0] case SC_EXEEDBREAK: val1 *= 150; // 150 * skill_lv if( sd && sd->inventory_data[sd->equip_index[EQI_HAND_R]] ) { // Chars. val1 += (sd->inventory_data[sd->equip_index[EQI_HAND_R]]->weight/10 * sd->inventory_data[sd->equip_index[EQI_HAND_R]]->wlv * status->get_lv(bl) / 100); val1 += 15 * (sd ? sd->status.job_level:50) + 100; } else // Mobs val1 += (400 * status->get_lv(bl) / 100) + (15 * (status->get_lv(bl) / 2)); // About 1138% at mob_lvl 99. Is an aproximation to a standard weapon. [pakpil] break; [/code]Replace it with:[code=auto:0] case SC_EXEEDBREAK: val1 *= 150; // 150 * skill_lv if( sd ) { if( sd->equip_index[EQI_HAND_R] >= 0 && sd->inventory_data[sd->equip_index[EQI_HAND_R]] ) { val1 += (sd->inventory_data[sd->equip_index[EQI_HAND_R]]->weight/10 * sd->inventory_data[sd->equip_index[EQI_HAND_R]]->wlv * status->get_lv(bl) / 100); val1 += 15 * (sd ? sd->status.job_level:50) + 100; } } else // Mobs val1 += (400 * status->get_lv(bl) / 100) + (15 * (status->get_lv(bl) / 2)); // About 1138% at mob_lvl 99. Is an aproximation to a standard weapon. [pakpil] break; [/code]

[color=#009acd][font='trebuchet ms', helvetica, sans-serif]^ its nice if your going to make a pull request for that. :meow:[/font][/color]

Well, I have one pull request that's been in that list for a week now, I'll see if I can make one today c:
Also I've documented skill_require_db, figuring out how to edit that thing was a mess:
[url="http://pastebin.com/nvZmBkYh"]http://pastebin.com/nvZmBkYh[/url]



EDIT:
Already made pull request, but somehow it merged with my last one...
[url="https://github.com/HerculesWS/Hercules/pull/254"]https://github.com/HerculesWS/Hercules/pull/254[/url]

[color=#009acd][font='trebuchet ms', helvetica, sans-serif]^ Haha thats nice, lets wait for devs to take a look at it.[/font][/color]

Fixed @ 9b5bb9aa894d63d1d9f2cafa91f90bc4922bf414

Thanks pan..

:meow:

[quote name="malufett" timestamp="1392027282"]
Fixed @ 9b5bb9aa894d63d1d9f2cafa91f90bc4922bf414

Thanks pan..

:meow:[/quote]

can you link it again where i can see the fix

[quote name="HisokaMachi" timestamp="1394302455"][quote name="malufett" timestamp="1392027282"]

Fixed @ 9b5bb9aa894d63d1d9f2cafa91f90bc4922bf414

Thanks pan..

:meow:[/quote]
can you link it again where i can see the fix[/quote]

[url="https://github.com/HerculesWS/Hercules/commit/9b5bb9aa894d63d1d9f2cafa91f90bc4922bf414"]https://github.com/HerculesWS/Hercules/commit/9b5bb9aa894d63d1d9f2cafa91f90bc4922bf414[/url]