karazu - Feb 22, 2014 19:06
My Cart will gone every time I character select..
anyone can confirm?
Latest Rev
ossi0110 - Feb 22, 2014 20:57
confirm , even on a clean rev
tested in pre-re mode
BFPkiller - Feb 23, 2014 6:59
Confirmed in Renewal to.
Samuel - Feb 25, 2014 0:49
Confirmed also..
kyeme - Feb 25, 2014 0:50
I can confirm this
sc_config.txt can't solve the problem. /sob
This post has been edited by
kyeme
on Feb 25, 2014 1:16
Hadeszeus - Feb 27, 2014 2:00
Confirmed :(
This post has been edited by
Hadeszeus
on Feb 27, 2014 2:03
AnnieRuru - Feb 27, 2014 4:51
confirm too
no.1
the cart is actually can be done with setoption[code=auto:0]prontera,157,183,5 script kjdhfkjshf 100,{
setoption 0x100, 1;
}[/code]exact same script
on rathena works
on hercules, it doesn't even gives you a cart
no.2[code=auto:0]prontera,154,183,5 script kjdhfkjshf2 100,{
if ( checkcart() ) {
if ( checkoption(0x8) ) .@cart = 1;
if ( checkoption(0x80) ) .@cart = 2;
if ( checkoption(0x100) ) .@cart = 3;
if ( checkoption(0x200) ) .@cart = 4;
if ( checkoption(0x400) ) .@cart = 5;
dispbottom "you have cart no."+ .@cart;
}
else
dispbottom "no cart";
end;
}[/code]on rathena, having a cart, this sample will tell you which cart you are having
on hercules, nope, checkcart() ok, but checkoption all return 0
no.3
cart is saves in `option` column in `char` table
on rathena, having cart no.1 save as 8
on hercules, having a cart, logout, remains 0
I just read pc.h[code=auto:0]#ifdef NEW_CARTS
#define pc_iscarton(sd) ( (sd)->sc.data[SC_PUSH_CART] )
#else
#define pc_iscarton(sd) ( (sd)->sc.option&OPTION_CART )
#endif[/code]hmm ...........
ok ... it actually save in `sc_data` table ...
.... haha ...
that means now we have 9 carts
This post has been edited by
AnnieRuru
on Feb 27, 2014 5:23
Tepoo - Feb 27, 2014 9:31
the bug came in when they tryed to fix the bug with the permanent stats who where written in the database twice on login.
also +1 confirmed
Beret - Mar 6, 2014 15:35
Bump.
Flash - Mar 6, 2014 20:54
I think this bug was causes by the rewrite of the sc code quite soon after the last sc bug was fixed ^^
it happens ones a char logs out. there is a function that checks for invalid status effects. however this functions considers all status effects with a -1 tick as invalid. because of this all permanent status effects are removed once you log of. mounts, sitting, taekwon stances, carts...
here is my debug log (1 is the start of the function and 2 is the end of the function):[quote]
[Info]: save_scdata_single()1
[Info]: save_scdata_single()2
[Info]: Character 'test' logged off.
[Info]: chrif_Save()1
[Info]: chrif_save_scdata()1
[Info]: chrif_save_scdata()2
[Info]: chrif_Save()2
[Info]: status_change_end_(...)1
[Info]: chrif_del_scdata_single(2000000, 150000, 517)
[Info]: status_change_end_(...)2
[Info]: chrif_save_ack()1
[Info]: chrif_save_ack()2[/quote]The sc values are saved correctly but then status_change_end_ removes this status. Unfortunately I have no idea what exactly status_change_end_ is supposed to do so I couldn't fix it myself.
Frost - Mar 8, 2014 7:49
Bump! :(
Alexandria - Mar 8, 2014 7:53
[font='comic sans ms', cursive][color=rgb(238,130,238)]and another bump[/color][/font]
snowflake1963 - Mar 8, 2014 17:27
I can confirm this
orange - Mar 8, 2014 19:49
Even i confirm this. Even My players are having the same problem,
Shackles - Mar 9, 2014 10:22
Lol, Since febuary this has been happening and not even a reply from the developer or any solution?
This is a big problem which needs to be resolved.
kyeme - Mar 10, 2014 0:11
Bumper~ :D
Hadeszeus - Mar 10, 2014 2:35
I agree with Shackles. This should be fix. It's really annoying to the players.
evehour - Mar 10, 2014 13:53
bump...
This post has been edited by
evehour
on Mar 10, 2014 14:03
Shackles - Mar 10, 2014 19:00
bump da bump..
Eiphes - Mar 10, 2014 19:31
Confirmed; I'll service anyone who posts a fix. xoxo<3
Temp fix inspired by ossi's sexy face:
add to an OnPCLoginEvent: script the following:
if (getskilllv(39) >= 1) {atcommand "@cart 9"; dispbottom "Notice: As a temporary fix, players with Push Cart Level 1 or higher will all have a cart assigned to them upon login since it disappears otherwise.";}
Shout praise.
This post has been edited by
Eiphes
on Mar 10, 2014 19:51
Ind - Mar 10, 2014 20:03
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/73ab0c441de0f74c2e621a594df7e269ce89bfc5"]https://github.com/HerculesWS/Hercules/commit/73ab0c441de0f74c2e621a594df7e269ce89bfc5[/url]
kyeme - Mar 10, 2014 20:22
[quote name="Ind" timestamp="1394481833"]
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/73ab0c441de0f74c2e621a594df7e269ce89bfc5"]https://github.com/HerculesWS/Hercules/commit/73ab0c441de0f74c2e621a594df7e269ce89bfc5[/url][/quote]
Its working fine now, thank you Sir!
Adam - Mar 10, 2014 23:08
Great job, thank you.