1. Hercules bug tracker archive
  2. Hercules Bug Archives
  3. Core
  4. *jobname with invalid ID return ... "Tomb" ??

*jobname with invalid ID return ... "Tomb" ??

Issue information

Issue ID
#8057
Status
Fixed
Severity
None
Started
AnnieRuru
Feb 26, 2014 14:09
Last Post
Haru
Feb 26, 2014 23:59
Confirmation
N/A

AnnieRuru - Feb 26, 2014 14:09

[code=auto:0]prontera,164,171,3 script MvP Ladder Warper 56,{ dispbottom jobname(-1); end; }[/code]same script

on rAthena -> Unknown Job
[attachment=1408:screenrAthena039.jpg]
on Hercules -> Tomb
[attachment=1407:screenHercules006.jpg]

what is Tomb ?
shouldn't it be "null" or something that is easier to understand ?

This post has been edited by AnnieRuru on Feb 27, 2014 18:26

bgamez23 - Feb 26, 2014 14:37

we can't see the image. :(

Haru - Feb 26, 2014 14:50

'Tomb' and 'Unknown job' have the same message ID.

This post has been edited by Ind on Feb 26, 2014 20:33

kyeme - Feb 26, 2014 15:10

[quote name="bgamez23" timestamp="1393425452"]
we can't see the image. :([/quote]
[url="http://herc.ws/board/index.php?app=core&module=attach&section=attach&attach_rel_module=post&attach_id=1407"]http://herc.ws/board/index.php?app=core&module=attach&section=attach&attach_rel_module=post&attach_id=1407[/url]
[url="http://herc.ws/board/index.php?app=core&module=attach&section=attach&attach_rel_module=post&attach_id=1408"]http://herc.ws/board/index.php?app=core&module=attach&section=attach&attach_rel_module=post&attach_id=1408[/url]

Haru - Feb 26, 2014 23:59

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/87b6c8f196897b72d98de2b1d4716bee1af99c3b"]https://github.com/HerculesWS/Hercules/commit/87b6c8f196897b72d98de2b1d4716bee1af99c3b[/url]

The issue was much bigger than it seemed, there were other messages re-using the same IDs, so I went for a cleanup of the messages.conf file. I hope I didn't introduce new issues with that.