in rathena -> working properly
[attachment=1428:screenrAthena040.jpg]
in hercules -> bug
[attachment=1429:screenHercules008.jpg]
only display test1 and doesn't display test2
Ind - Mar 1, 2014 20:01
i can see where this takes place (in pc_dead it cancels any ongoing npcs) however, isn't it meant to be a exploit-countermeasure? so that you can't maintain npc dialogs and use other functionality while dead
AnnieRuru - Mar 2, 2014 1:42
it only cancel npc dialog ( sd->npcid )
but doesn't cancel anything else
so let's say, I want to write a script that's kill everyone in the party[code=auto:0]prontera,156,189,5 script Raid 100,{
// kill everyone in the party
if ( !getcharid(1) ) {
percentheal -100,-100; // ok
end;
}
getpartymember getcharid(1), 1;
getpartymember getcharid(1), 2;
for ( .@i = 0; .@i < $@partymembercount; .@i++ ) {
if ( isloggedin( $@partymemberaid[.@i], $@partymembercid[.@i] ) ) {
attachrid $@partymemberaid[.@i];
percentheal -100,-100; // only kill the 1st player but doesn't kill the rest
}
}
end;
}[/code]exact same script
in rathena, works fine, every party member is dead
in hercules, only kill the 1st player but the rest survive
I prefer the way how rathena do it though
[url="https://github.com/rathena/rathena/blob/master/src/map/pc.c#L6881"]https://github.com/rathena/rathena/blob/master/src/map/pc.c#L6881[/url]
wait ... did I just see your name appear in rathena ? :o
This post has been edited by
AnnieRuru
on Mar 13, 2014 6:48
Adam - Mar 9, 2014 0:20
Hello, anything new regarding this bug ? Thx.
Ind - Mar 29, 2014 20:53
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/f0fc96a130ac67d894e44e922504504587b53bb3"]https://github.com/HerculesWS/Hercules/commit/f0fc96a130ac67d894e44e922504504587b53bb3[/url]