Issue information

Issue ID
#8077
Status
Fixed
Severity
None
Started
AnnieRuru
Mar 11, 2014 20:28
Last Post
AnnieRuru
Mar 17, 2014 11:49
Confirmation
Yes (2)
No (0)

AnnieRuru - Mar 11, 2014 20:28

[code=auto:0][Debug]: NPCEvent '::OnRecvCastlear01' not found! (source: Steward#ar01) [Debug]: NPCEvent '::OnRecvCastlear02' not found! (source: Steward#ar02) [Debug]: NPCEvent '::OnRecvCastlear03' not found! (source: Steward#ar03) [Debug]: NPCEvent '::OnRecvCastlear04' not found! (source: Steward#ar04) [Debug]: NPCEvent '::OnRecvCastlear05' not found! (source: Steward#ar05) [Debug]: NPCEvent '::OnRecvCastlesc01' not found! (source: Steward#sc01) [Debug]: NPCEvent '::OnRecvCastlesc02' not found! (source: Steward#sc02) [Debug]: NPCEvent '::OnRecvCastlesc03' not found! (source: Steward#sc03) [Debug]: NPCEvent '::OnRecvCastlesc04' not found! (source: Steward#sc04) [Debug]: NPCEvent '::OnRecvCastlesc05' not found! (source: Steward#sc05)[/code].
.
problem from this line
[url="https://github.com/HerculesWS/Hercules/blob/master/npc/guild2/agit_main_se.txt#L626"]https://github.com/HerculesWS/Hercules/blob/master/npc/guild2/agit_main_se.txt#L626[/url]

[b]source: Steward#ar01[/b]
strnpcinfo(2) = ar01
but see all the labels are actually has a case-sensitive -> Ar01
[url="https://github.com/HerculesWS/Hercules/blob/master/npc/guild2/arug_cas01.txt#L48"]https://github.com/HerculesWS/Hercules/blob/master/npc/guild2/arug_cas01.txt#L48[/url]

instead of changing all 10 files,
how about change the template itself with[code=auto:0]donpcevent "::OnRecvCastle"+ strtoupper( substr( strnpcinfo(2), 0, 0 ) ) + substr( strnpcinfo(2), 1, getstrlen( strnpcinfo(2) ) -1 );[/code]because the WoE 1st version also has capital letters

Good Job Euphy !

AnnieRuru - Mar 16, 2014 18:28

suddenly I gained the permission to submit to the main branch o.o

fixed in
[url="https://github.com/HerculesWS/Hercules/commit/1c495a071e907286ebe929dec9a8ead8582aee82"]https://github.com/HerculesWS/Hercules/commit/1c495a071e907286ebe929dec9a8ead8582aee82[/url]

Euphy - Mar 17, 2014 0:53

[quote name="AnnieRuru" timestamp="1394569697"]
Good Job Euphy ![/quote]They're not case-sensitive in rAthena. -__-;

AnnieRuru - Mar 17, 2014 11:49

[quote name="Euphy" timestamp="1395017614"]
They're not case-sensitive in rAthena. -__-;[/quote]yes, that's the reason :>
the script works fine in rathena, but will be bug in hercules lol

if it is bug in rathena, I would have reported in rathena forum