Issue information

Issue ID
#811
Status
Fixed
Severity
Critical
Started
Hercules Elf Bot
Jan 14, 2008 3:34
Last Post
Hercules Elf Bot
Jan 14, 2008 3:34
Confirmation
N/A

Hercules Elf Bot - Jan 14, 2008 3:34

Originally posted by [b]Yhn[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=811

After some searching I found a update message from rev 225 of Lupus about it; that might be it. (some Freya merge...) It's still in 12071 anyhoo.

Anyhoo, some retarded person - Yor, probably from Freya - had the most clever idea to use vending_max_value as top limit for a input box.

To the current day, this has been used...

Now, I am wondering why no one even thought of changing that limit to MAX_ZENY, or MAX_INT... since those DO make at least SOME sense there =|
CODE
sd->npc_amount = cap_value(sd->npc_amount, 0, battle_config.vending_max_value);

I mean, come on... what if someone decides on his server to put the vending_max_value to 10,000,000? I know the chance of that happening is (very) low, but why keep this retardish naive way of hard limiting the input? x.x

Okay, it's not really a bug, yet, untill someone; maybe even kRO in a weird mood; changes the max vending value...