Issue information

Issue ID
#8160
Status
Unable to Fix
Severity
High
Started
OmegaRed
Apr 21, 2014 22:41
Last Post
pan
May 7, 2014 0:17
Confirmation
Yes (0)
No (1)

OmegaRed - Apr 21, 2014 22:41

[code=auto:0] gdb) bt full #0 geoip_getcountry (ipnum=3142518760) at inter.c:421 depth = <value optimized out> x = <value optimized out> buf = 0x7ffff99f63b2 <Address 0x7ffff99f63b2 out of bounds> offset = <value optimized out> #1 0x0000000000426a4d in mapif_parse_accinfo2 (success=<value optimized out>, map_fd=10, u_fd=146, u_aid=1000XXX, account_id=200XXXX, userid=0x74a092 "mXXXXXX", user_pass=0x74a0aa "159XXXXXX[", email=0x74a0cb "[email protected]", last_ip=0x74a0f3 "187.XXX.XXX.XXX", lastlogin=0x74a107 "2014-04-21 18:03:47", pin_code=0x74a127 "XXXX", birthdate=0x74a12c "0000-00-00", group_id=2, logincount=5, state=0) at inter.c:560 No locals. #2 0x000000000041ddcd in parse_fromlogin (fd=9) at char.c:2615 command = <value optimized out> sd = <value optimized out> #3 0x000000000044343e in do_sockets (next=<value optimized out>) at socket.c:872 rfd = {__fds_bits = {512, 0 <repeats 15 times>}} timeout = {tv_sec = 0, tv_usec = 185754} ret = 0 i = <value optimized out> #4 0x000000000043f9e1 in main (argc=<value optimized out>, argv=<value optimized out>) at core.c:250 next = <value optimized out> [/code]
Char-server crash when I use @ accinfo "char name" or "partial char name" (%John%).

Ind - Apr 21, 2014 23:07

does it crash on any char name?

OmegaRed - Apr 21, 2014 23:19

I used the command on the production server, after crashed not tested more.

This post has been edited by OmegaRed on Apr 21, 2014 23:20

OmegaRed - Apr 21, 2014 23:28

Tested on my beta server and same problem, crash on @accinfo with any char name.

Haru - Apr 22, 2014 0:07

Can you try to re-download the GeoIP.dat file from the Hercules repository? I suspect you have a corrupted version of the file. You can download a clean copy from [url="https://github.com/HerculesWS/Hercules/blob/master/db/GeoIP.dat"]https://github.com/HerculesWS/Hercules/blob/master/db/GeoIP.dat[/url] (click the Raw button), or simply clone the git repository again.

While I can't reproduce the issue on a clean copy, I'm marking this issue as confirmed, since I can get it to crash with a corrupted .dat file, and we're not doing any checks during/after the file is loaded.

Please let us know if a clean copy of the file fixes the issue for you, and if it doesn't, it'd be nice to know what operating system/version your server is running on, so we can test in a similar environment.

OmegaRed - Apr 22, 2014 0:39

yes, GeoIP.dat Corrupted.
Replaced GeoIP.dat and now is working ok

thks

This post has been edited by OmegaRed on Apr 22, 2014 0:40

pan - Apr 28, 2014 22:21

Just waiting some more info regarding our geoip.dat before commiting this fix.

This post has been edited by pan on Apr 28, 2014 22:21

pan - May 7, 2014 0:17

Couldn't fix this completely [url="https://github.com/HerculesWS/Hercules/commit/9a425c11b61fb6f4e299013c7d8d9841129b8f45"]https://github.com/HerculesWS/Hercules/commit/9a425c11b61fb6f4e299013c7d8d9841129b8f45[/url]