Issue information

Issue ID
#8248
Status
Fixed
Severity
None
Started
Ridley
Jul 4, 2014 10:19
Last Post
Mumbles
Aug 2, 2014 11:54
Confirmation
Yes (1)
No (0)

Ridley - Jul 4, 2014 10:19

When changing job from Novice to [b]Baby[/b], your skills and skillpoints are not reset. So on jlvl 10 you have 9 Skill points, but Basic Skill on 9 and the npc keep telling you to use your skill points first.

Edit: fixed typo

This post has been edited by Ridley on Jul 5, 2014 6:34

Enhance - Jul 4, 2014 21:00

This doesn't seem like a job master bug.

Also, could you elaborate on the process again? I'm confused on how you got a Novice to have level 9 Base Skills and 9 skpoints.

Ridley - Jul 4, 2014 21:29

1. Make a new char
2. Lvl to jlvl 10 and get your Basic skill on lv. 9 to get your first job
3. Talk to the Job Master and become a Baby class. It will reset your jlvl to 0, but your Basic skill is still Lv. 9
When you level to jlvl 10 again you have the New 9 skill points and Basic skill already maxed

Enhance - Jul 5, 2014 0:02

Got it, you said supernovice, not a baby in your post.

Anyway, I can confirm that. I suppose the way to work it out is manually interfere with that particular job change - either resetting character completely, or just taking away Basic Skills and all skill points:

Resetting the character (affects base level as well, which is rude):
[spoiler][code=auto:0] jobchange .@newjob; if (.@newjob == Job_Novice_High || .@newjob == Job_Baby) resetlvl(1); specialeffect2 EF_ANGEL2; specialeffect2 EF_ELECTRIC; [/code][/spoiler]

Meddling with skill points (manually modifies skill point amount, which is also rude):
[spoiler][code=auto:0] jobchange .@newjob; if (.@newjob == Job_Novice_High) resetlvl(1); if (.@newjob == Job_Baby) { resetskill; set SkillPoint, 0; } specialeffect2 EF_ANGEL2; specialeffect2 EF_ELECTRIC; [/code][/spoiler]

This post has been edited by Enhance on Jul 5, 2014 0:04

Ridley - Jul 5, 2014 6:33

[quote name="Enhance" timestamp="1404518562"]
Got it, you said supernovice, not a baby in your post.[/quote]

oops, happens when posting drunk.
However, i think the most simple way is to require job/base level 1 to transform into Baby.

Enhance - Jul 5, 2014 7:43

[quote name="Ridley" timestamp="1404542030"]
However, i think the most simple way is to require job/base level 1 to transform into Baby.[/quote]I thought that, but [i]technically[/i], you're not required to be 1/1 to be adopted.

Ridley - Jul 5, 2014 12:45

[quote name="Enhance" timestamp="1404546181"]
I thought that, but [i]technically[/i], you're not required to be 1/1 to be [b]adopted[/b].[/quote]

And thats the point, since it's not intended to become baby using a npc. Right now i just can't think of any other way then setting b/j lvl 1 as requirement.

edit: or maybe, preventing the script to reset your job level back to 0 <-- lol i don't know why i haven't thought of this.

This post has been edited by Ridley on Jul 5, 2014 12:47

Enhance - Jul 5, 2014 16:09

[quote name="Ridley" timestamp="1404564351"]

[quote name="Enhance" timestamp="1404546181"]
I thought that, but [i]technically[/i], you're not required to be 1/1 to be [b]adopted[/b].[/quote]And thats the point, since it's not intended to become baby using a npc. Right now i just can't think of any other way then setting b/j lvl 1 as requirement.

[/quote]I already gave two other solutions, so why can't you?[quote]
edit: or maybe, preventing the script to reset your job level back to 0 <-- lol i don't know why i haven't thought of this.[/quote]Script doesn't separately reset your job level to 1, jobchange itself does. So you can't do that without changing that very script command.

This post has been edited by Enhance on Jul 5, 2014 16:09

Ridley - Jul 5, 2014 17:04

well, as said, most simple way is to do a manual reset
find:[code=css:159] if (.@newjob == Job_Novice_High) resetlvl(1); [/code]

add below
[code=css:161] if (.@newjob == Job_Baby) resetskill; SkillPoint = 0; [/code]

This post has been edited by Ridley on Jul 5, 2014 18:28

Fluffle Puff - Jul 9, 2014 19:38

[color=#ee82ee][font='comic sans ms', cursive]does it really happen?[/font][/color]

Mumbles - Jul 28, 2014 9:05

Confirmed, but your pull request needs to be updated before it can be merged.

[url="https://github.com/HerculesWS/Hercules/pull/306"]https://github.com/HerculesWS/Hercules/pull/306[/url]

Mumbles - Aug 2, 2014 11:54

Went ahead and updated this in [url="https://github.com/HerculesWS/Hercules/commit/3961c4cba6e4686d0babb59be917b971479f7780"]3961c4c[/url] since it's been pending for 5 days. Thanks for your contribution!