Issue information

Issue ID
#8317
Status
Fixed
Severity
None
Started
4144
Sep 3, 2014 12:00
Last Post
Ind
Sep 20, 2014 19:43
Confirmation
N/A

4144 - Sep 3, 2014 12:00

If not add this check, server will allocate maximum allowed buffer and will flood client with 0x6c packet.

4144 - Sep 3, 2014 12:01

Fix in pull request [url="https://github.com/HerculesWS/Hercules/pull/332"]https://github.com/HerculesWS/Hercules/pull/332[/url]

Frost - Sep 3, 2014 12:28

How do you reproduce your issue?

4144 - Sep 3, 2014 16:58

This is long story.
I writing open source client. It works with very old eathena fork and fork from this old fork.
Client using own opensource/free art, nothing related to RO.
Now i trying to add support for hercules.
I ignored pincode packet and try to select char, and got this issue.
Fix is trivial, and i reported it here.

If need I can give more details how get/test client

Ind - Sep 20, 2014 19:43

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/4d138cbe8c0071d0fc81020e2ff4078d31c8760a"]https://github.com/HerculesWS/Hercules/commit/4d138cbe8c0071d0fc81020e2ff4078d31c8760a[/url]
Thank you very much!