Issue information

Issue ID
#8430
Status
Fixed
Severity
None
Started
zackdreaver
Nov 9, 2014 7:02
Last Post
Makoto
Apr 7, 2015 12:49
Confirmation
Yes (2)
No (0)

zackdreaver - Nov 9, 2014 7:02

Hello dev,
i just realise that monster stop attacking after got hitted

how to produce :
- Attack monster with melee (agressif or pasif)
- move a few cells from monster
- monster will chase you but wont attack you (sometime)
- move a few cells again from monster and they will attack you.


maybe related to this commit?
5d24944d2b8d0a06f85bd440614f3c12bf37143f

already tried to change "monster_chase_refresh" from "3" and "1" , but got no luck

no problem in latest rathena, both renewal and prerenewal

Zer Wildblood - Nov 9, 2014 9:32

I am confirming this..

keikun19 - Nov 9, 2014 12:33

same here

Playtester - Nov 9, 2014 20:33

Strange, so it works on rAthena but not on Hercules?

EDIT: Okay found the bug:[code=auto:0] //Attempt to attack. //At this point we know the target is attackable, we just gotta check if the range matches. if (battle->check_range(&md->bl, tbl, md->status.rhw.range) && !(md->sc.option&OPTION_HIDE)) { //Target within range and able to use normal attack, engage if (md->ud.target != tbl->id || md->ud.attacktimer == INVALID_TIMER) { //Only attack if no more attack delay left if(tbl->type == BL_PC) mob->log_damage(md, tbl, 0); //Log interaction (counts as 'attacker' for the exp bonus) } return true; }[/code]
It's because Michieru accidentally removed the whole monster attack routine instead of just the random attack routine in this commit:
[url="https://github.com/HerculesWS/Hercules/commit/cf18e5578f85bc6c368a2ad4d7c746af8687c7f0"]https://github.com/HerculesWS/Hercules/commit/cf18e5578f85bc6c368a2ad4d7c746af8687c7f0[/url]

To fix it:[code=auto:0] { //Only attack if no more attack delay left if(tbl->type == BL_PC) mob_log_damage(md, tbl, 0); //Log interaction (counts as 'attacker' for the exp bonus) unit_attack(&md->bl,tbl->id,1); }[/code]

Michi - Nov 9, 2014 20:46

Fixed in: [url="https://github.com/HerculesWS/Hercules/commit/c1e1099c701de325a076172bcadf544e5b3000c9"]https://github.com/HerculesWS/Hercules/commit/c1e1099c701de325a076172bcadf544e5b3000c9[/url]

Sorry for this =(

keikun19 - Nov 9, 2014 21:26

Excelent Work Muchi! :D

Makoto - Apr 4, 2015 4:57

Michi i want to bump because this problem is happening again..

zackdreaver - Apr 4, 2015 5:42

i think i can confirm this when they attack with magic.
tested on magmaring with my AB:
when i attack it, he attack me
then i use judex few cells from the mobs,
Magmaring then use magic (fire ball maybe?),
he casted on my AB, after that he stop attacking.

Btw, afaik in official, when monster attacking, there should be delay before he begin chase after the attacker.
but in hercules if he attack me, then i move a few cells, he will quickly chase me.

Makoto - Apr 7, 2015 12:49

Well yeah, i noticed this when im luring Alarm monsters.