Issue information

Issue ID
#8511
Status
Fixed
Severity
None
Started
nihadm89
Jan 27, 2015 12:59
Last Post
Dastgir
Jan 28, 2015 11:06
Confirmation
Yes (1)
No (0)

nihadm89 - Jan 27, 2015 12:59

Not sure if it is because of this update: [url="https://github.com/HerculesWS/Hercules/commit/e99cbac3f1d0354566da5887ab4f01c6737dd0de#diff-5"]https://github.com/HerculesWS/Hercules/commit/e99cbac3f1d0354566da5887ab4f01c6737dd0de#diff-5[/url]

But the New Oz NPC on line 13054 is kinda messed up.
You can repeat the Food support one infinite times and if you look while the server is running when trying to do any of the quests you get missing quest errors.

Edit:
Also
[b]Slot Expert Nattuer NPC[/b] all enchantment attempts will fail now.
Issue was at line 935
if ( .@luckyday%20 ){
Changed to:
if ( .@luckyday < 5 ){

However I am not sure if that chance matches the official.

This post has been edited by nihadm89 on Jan 27, 2015 14:04

Dastgir - Jan 27, 2015 17:09

Will update the New Oz next day.
About slot enchanter, in official it's like, if you have got numbers like 20,40,60,80,.. then only it will pass, so I guess that's the official implementation.

This post has been edited by Dastgir on Jan 27, 2015 17:12

nihadm89 - Jan 27, 2015 20:21

You should confirm that though, we did a lot of testing and failed 100% of the time. Also had players report that they were failing 100% of the time. Maybe it's just our insane bad luck. Soon as I changed it things went back to normal.

Dastgir - Jan 28, 2015 5:27

[quote name="nihadm89" timestamp="1422390074"]
You should confirm that though, we did a lot of testing and failed 100% of the time. Also had players report that they were failing 100% of the time. Maybe it's just our insane bad luck. Soon as I changed it things went back to normal.[/quote]

Condition for passing as per data we have[code=:0] if ((ur_luckyday == 20) | (ur_luckyday == 40) | (ur_luckyday == 60) | (ur_luckyday == 80) | (ur_luckyday == 100)) [/code]
(though was missing the 100 check in hercules repo)

Fixed @ [url="https://github.com/HerculesWS/Hercules/commit/1b0eacd770b128b02d3300b7efe05da136bbed3d"]https://github.com/HerculesWS/Hercules/commit/1b0eacd770b128b02d3300b7efe05da136bbed3d[/url]

nihadm89 - Jan 28, 2015 6:32

Thank you. :D
I'll have my team test everything and confirm it today, I'll let you know if there are any other issues.

nihadm89 - Jan 28, 2015 6:57

Slot enchanter is good now.
Oz is still a bit wacky.

[Error]: quest_delete: Character ##### doesn't have quest 13062.
Got this error when attempting to do the quest the first time.
And I was still able to do the quest twice in a row, after that it seems to have gone back to normal.

Also minor issue:


[Warning]: misuse of 'close2'! trying to use it without prior dialog! skipping...
[Debug]: Source (NPC): New Oz#1 at ecl_tdun03 (68,80)

When trying to do the other quests:

[Error]: quest_change: Character ##### doesn't have quest 13066.

[Error]: quest_change: Character ##### doesn't have quest 13064.


So it seems the check for which quests you have is still a bit off.

This post has been edited by nihadm89 on Jan 28, 2015 6:58

Dastgir - Jan 28, 2015 7:47

[quote name="nihadm89" timestamp="1422428268"]
Slot enchanter is good now.
Oz is still a bit wacky.

[Error]: quest_delete: Character ##### doesn't have quest 13062.
Got this error when attempting to do the quest the first time.
And I was still able to do the quest twice in a row, after that it seems to have gone back to normal.

Also minor issue:


[Warning]: misuse of 'close2'! trying to use it without prior dialog! skipping...
[Debug]: Source (NPC): New Oz#1 at ecl_tdun03 (68,80)

When trying to do the other quests:

[Error]: quest_change: Character ##### doesn't have quest 13066.

[Error]: quest_change: Character ##### doesn't have quest 13064.


So it seems the check for which quests you have is still a bit off.[/quote]
close2; is cause of something else, which is reported to respective dev, and let's see what will be appropriate solution for close2;
other will be fixed after close2

This post has been edited by Dastgir on Jan 28, 2015 7:48

Dastgir - Jan 28, 2015 11:04

[quote]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3][Error]: quest_delete: Character ##### doesn't have quest 13062.[/size][/font][/color]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Got this error when attempting to do the quest the first time.[/size][/font][/color]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]And I was still able to do the quest twice in a row, after that it seems to have gone back to normal.[/size][/font][/color]

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Also minor issue:[/size][/font][/color]

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]When trying to do the other quests:[/size][/font][/color]

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3][Error]: quest_change: Character ##### doesn't have quest 13066.[/size][/font][/color]

[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3][Error]: quest_change: Character ##### doesn't have quest 13064.[/size][/font][/color]
[/quote]
Been Fixed at [url="https://github.com/HerculesWS/Hercules/commit/7d93099232dcf3c74349a99d9fa891927f2351d6"]https://github.com/HerculesWS/Hercules/commit/7d93099232dcf3c74349a99d9fa891927f2351d6[/url]


[code=auto:0] [Warning]: misuse of 'close2'! trying to use it without prior dialog! skipping... [Debug]: Source (NPC): New Oz#1 at ecl_tdun03 (68,80) [/code]
^ Will be fixed very soon(since its core mistakes, rather than script)