Issue information

Issue ID
#8535
Status
Fixed
Severity
None
Started
kyeme
Feb 15, 2015 16:05
Last Post
Ind
Mar 5, 2015 17:19
Confirmation
N/A

kyeme - Feb 15, 2015 16:05

I'm not using latest

[img]http://i.imgur.com/Mk2YaNM.jpg[/img]

Line 6159 (Red):

[quote]

if ( dstsd && dstsd->spiritball
[color=#ff0000]&& (sd == dstsd || map_flag_vs(src->m) || (sd->duel_group && sd->duel_group == dstsd->duel_group))[/color]
&& ((dstsd->class_&MAPID_BASEMASK) != MAPID_GUNSLINGER || (dstsd->class_&MAPID_UPPERMASK) != MAPID_REBELLION)
) {[/quote]


Line 5084:

[quote]

if (skill->get_casttype(ud->skill_id) == CAST_NODAMAGE)
[color=#ff0000]skill->castend_nodamage_id(src,target,ud->skill_id,ud->skill_lv,tick,flag);[/color]
else
skill->castend_damage_id(src,target,ud->skill_id,ud->skill_lv,tick,flag);[/quote]


Thank you.

Playtester - Feb 17, 2015 10:06

It is missing a check for "sd". So if sd is NULL sd->duel_group crashes the map server.

Ind - Mar 5, 2015 17:17

Indeed. I'm assuming a monster or a clone did it.

Ind - Mar 5, 2015 17:19

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/cb8bd9042d2c589421d6b6f1c9a63122d59a4d47"]https://github.com/HerculesWS/Hercules/commit/cb8bd9042d2c589421d6b6f1c9a63122d59a4d47[/url]