Issue information

Issue ID
#86
Status
Fixed
Severity
Low
Started
Hercules Elf Bot
Sep 21, 2007 17:58
Last Post
Ind
Apr 16, 2013 6:20
Confirmation
N/A

Hercules Elf Bot - Sep 21, 2007 17:58

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=86

(Originally reported [url="http://www.eathena.ws/board/Login-id1-2-t161093.html"]in this topic[/url])

//TODO:
[code]account->login_id1 = rand();
account->login_id2 = rand();
[/code]

well,
1. on windows, these things only go up to 32k (N> good random generator)
2. at least one part of the code uses '0' as a special/invalid value, so the interval needs to be shifted

This post has been edited by Brian on Jan 18, 2012 19:56

Hercules Elf Bot - Jan 17, 2012 18:08

Originally posted by [b]Gepard[/b]
First part fixed in [rev=15483]

Ind - Apr 16, 2013 6:20

Fixed the remaining part in [url="https://github.com/HerculesWS/Hercules/commit/8ec2352c28f7495b7e3c81a8920e40b57d5074e9"]https://github.com/HerculesWS/Hercules/commit/8ec2352c28f7495b7e3c81a8920e40b57d5074e9[/url]