Parasite and Harpy card

Interesting, yes indeed those cards seem to have been wrong since forever.

waiting for dev...

[quote name="zackdreaver" timestamp="1430044951"]
Based on : [url="http://forums.warpportal.com/index.php?/topic/127843-fix-that-item-description-project/page-5#entry2123610"]http://forums.warpportal.com/index.php?/topic/127843-fix-that-item-description-project/page-5#entry2123610[/url]

parasite card :[code=auto:0] Official description: Reduce damage from NEUTRAL attack by 5% (Wrong) Hercules: bonus2 bSubEle,Ele_Neutral,5; (Wrong) AEGIS: AddRaceTolerace RACE_Nothing 5 (Right) - Formless monster [/code]
Harpy card :[code=auto:0] Official description: Add 15% more tolerance against Neutral Attack (Wrong) Hercules: bonus2 bSubEle,Ele_Neutral,15; (Wrong) AEGIS: AddRaceTolerace RACE_Nothing 15 (Right) - Formless monster [/code]
From what i've experienced,
Sometime KRO got mixed in their desc that "Nothing" became "Neutral" element,
though in some case they should be "Formless" monster[/quote]


will be fixed soon

Fixed
[url="https://github.com/HerculesWS/Hercules/commit/d87ac75610f69b34a20340193555cd174172edcf"]https://github.com/HerculesWS/Hercules/commit/d87ac75610f69b34a20340193555cd174172edcf[/url]

Is there any reason why this fix wasn't ported to pre-renewal as well?
In a pre-renewal (2006 or so) special.sc, I can see that those cards are already using AddRaceTolerance.

[quote name="Haru" timestamp="1430815970"]
Is there any reason why this fix wasn't ported to pre-renewal as well?
In a pre-renewal (2006 or so) special.sc, I can see that those cards are already using AddRaceTolerance.[/quote]
cause ea dev sucks with the item bonuses implementation, they don't have collaboration on how it will be implemented...
honestly I'm not used to pRe, cause I only play before and I don't know how to deal with it, so I added AddRaceTolerance only in RE knowing how it works and where does it belong with the ATK formula,,,

:meow:

I don't think this is a good idea, everyone's used to those bonuses and cards aren't even good to begin with, this change would make them even worse.

[quote name="Anisotropic Defixation" timestamp="1430834981"]
I don't think this is a good idea, everyone's used to those bonuses and cards aren't even good to begin with, this change would make them even worse.[/quote]
why could it be worse? it will be better cause converting from aegis will be easy so all discrepancy will be fixed..also converters will be available when its done...
[quote]
[size=3][background=rgb(247,247,247)]everyone's used to those bonuses and cards aren't even good to begin with[/background][/size][/quote]
exactly this is what I don't want to happen make users to be used for what is not intended..

:meow:

I don't see why they shouldn't be fixed.
Commit messages have the purpose to explain the commit details, so server owners will be informed (if they care), and can decide whether to undo the changes.