Issue information

Issue ID
#8666
Status
Needs more Info
Severity
None
Started
Shio
May 7, 2015 8:02
Last Post
Anisotropic Defixation
Jun 1, 2015 23:28
Confirmation
Yes (1)
No (0)

Shio - May 7, 2015 8:02

After i click an NPC or two this is displayed along with freezing the player in its current position. On latest Hercules fresh copy.

Dastgir - May 7, 2015 9:14

That is client sided message(I suppose), which means that you have script running, maybe you clicked too fast ? Or server is taking time to respond?

Shio - May 7, 2015 9:16

Also appears on first clicks once in a while, Even on simple things like Warper, Healer, Flag.

bgamez23 - May 7, 2015 10:07

its not client side issue. its a server side issue. this issue is already existed on old version and already been solved. but i haven't check it on the latest version.

bgamez23 - May 7, 2015 10:10

[url="http://herc.ws/board/tracker/issue-7271-any-work-in-progress-npc-dialog-manufactoring-quit-and-try-again/"]http://herc.ws/board/tracker/issue-7271-any-work-in-progress-npc-dialog-manufactoring-quit-and-try-again/[/url]

zackdreaver - May 7, 2015 10:26

so the issue is come back
i can confirm this on "healer" npc

evilpuncker - May 7, 2015 19:35

healer npc got a close; without having any window being displayed that's why.

Shio - May 8, 2015 6:50

[quote name="evilpuncker" timestamp="1431027317"]
healer npc got a close; without having any window being displayed that's why.[/quote]
[quote]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]after i click an NPC or two[/size][/font][/color][/quote]
I stated no specific npc. i can confirm this on any.

Dastgir - May 8, 2015 12:26

[quote name="Shio" timestamp="1431067810"][quote name="evilpuncker" timestamp="1431027317"]


healer npc got a close; without having any window being displayed that's why.[/quote][quote]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]after i click an NPC or two[/size][/font][/color][/quote]I stated no specific npc. i can confirm this on any.
[/quote]Don't click the healer, then try clicking other, does it happen that way too?

Anisotropic Defixation - May 8, 2015 13:09

This also happens when you close a shop after or before dialogue is terminated (shops called through a dialogue).

Script calls an open shop function > dialogue still remains open (used by the script to show various info) > if you click to close the shop while dialogue is active, this issue occurs.

Shio - May 8, 2015 17:55

[quote name="Dastgir" timestamp="1431087999"][quote name="Shio" timestamp="1431067810"]
[quote name="evilpuncker" timestamp="1431027317"]



healer npc got a close; without having any window being displayed that's why.[/quote][quote]ss="ipsBlockquote">
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]after i click an NPC or two[/size]<[/font][/color]/span>[/quote]I stated no specific npc. i can confirm this on any.[/quote]Don't click the healer, then try clicking other, does it happen that way too?[/quote]

any npc. I can reproduce this in any town on any npc.

Shio - May 8, 2015 17:57

[quote name="bgamez23" timestamp="1430993434"]
[url="http://herc.ws/board/tracker/issue-7271-any-work-in-progress-npc-dialog-manufactoring-quit-and-try-again/"]http://herc.ws/board/tracker/issue-7271-any-work-in-progress-npc-dialog-manufactoring-quit-and-try-again/[/url][/quote]
Or just edit your npcs.

Anisotropic Defixation - May 8, 2015 18:20

This happens regardless of using end; or close; in many cases.

malufett - May 9, 2015 7:30

[quote name="Anisotropic Defixation" timestamp="1431109219"]
This happens regardless of using end; or close; in many cases.[/quote]
cause this happens when you are in the state of npc interaction, warp dialog and magnifier dialog..this is normal and official..regarding this topic its a scripting mishandling..using 'close' without using 'mes'..to terminate a script 'end' must used..

:meow:

Anisotropic Defixation - May 9, 2015 8:11

Like I mentioned above, this happens in scripts that call a shop function while keeping dialogue open, regardless of using close; or end; I've tried multiple solutions with no avail.

This post has been edited by Anisotropic Defixation on May 13, 2015 5:06

Shio - May 10, 2015 16:46

[quote name="Anisotropic Defixation" timestamp="1431159085"]
Like I mentioned above, this happens in scripts that call a shop function while keeping dialogue open, regardless of using close; or end;, I've tried multiple solutions with no avail.[/quote]

I also can confirm this, especially after editing all my npcs. :(

Alexandria - May 10, 2015 17:47

[color=#ee82ee][font='comic sans ms', cursive]I can confirm this too. I told to ind to fix it but he told me that he cant reproduce the error. It happens with the healer.[/font][/color]

evilpuncker - May 13, 2015 5:01

I made a pull request, hope it gets accepted

@edit
made another pull request since the warper npc got the same problem (maybe that is why you guys says that it doesn't happen only with healer

This post has been edited by evilpuncker on May 13, 2015 5:17

Shio - May 16, 2015 6:20

@Evil Punker, Man for like the 100th time, i personally can produce it on [size=5][u][b]ANY NPC.[/b][/u][/size]

evilpuncker - May 16, 2015 13:31

if you can produce it[b] without any custom[/b] npc enabled then it is a real issue, since there are still some npcs in custom folder that still needs an update besides warper and healer

Dastgir - May 16, 2015 14:41

Warper and Healer are fixed. And as evilpuncker said, if you reproduce it with any other NPC, let us know, since I can't reproduce with any other NPC except warper and healer, which was fixed in past few commits.

Shio - May 18, 2015 4:12

Well i can make it work on any npc. at any map, at any time.

evilpuncker - May 18, 2015 4:36

mind making a video (and making sure that you are using latest hercules npcs (especially warper and healer :P)? I am not able to reproduce this error anymore

Anisotropic Defixation - May 30, 2015 18:47

Seems to also happen when you hit cancel (selection window) in some scripts, isn't cancel supposed to terminate the script as well?

Dastgir - May 31, 2015 2:02

[quote name="Anisotropic Defixation" timestamp="1433011626"]
Seems to also happen when you hit cancel (selection window) in some scripts, isn't cancel supposed to terminate the script as well?
[/quote]Mention the scripts,
If it's close2; without end;
It would cause maybe.

Anisotropic Defixation - Jun 1, 2015 23:28

Happens with scripts that use select(